archives

« Bugzilla Issues Index

#528 — 8.12.8: refactor away repetition

• bug_id: 528
• creation_ts: 2012-07-14 12:07:00 -0700
• short_desc: 8.12.8: refactor away repetition
• delta_ts: 2013-10-29 09:45:09 -0700
• product: Draft for 6th Edition
• component: editorial issue
• version: Rev 9: July 8, 2012 Draft
• rep_platform: All
• op_sys: All
• bug_status: RESOLVED
• resolution: FIXED
• priority: Normal
• bug_severity: enhancement
• everconfirmed: true
• reporter: Michael Dyck
• assigned_to: Allen Wirfs-Brock

---

• commentid: 1311
• comment_count: 0
• who: Michael Dyck
• bug_when: 2012-07-14 12:07:21 -0700

In 8.12.8 "[[DefaultValue]] (hint)",
there's a lot of repetition, which obscures what's going on.

I suggest refactoring the two algorithms (and the subsequent paragraph)
down to this:

When the [[DefaultValue]] internal method of /O/ is called with optional /hint/,
the following steps are taken:

1. If /hint/ is String or if /hint/ is not supplied and /O/ is a Date object,
Let propertyNamesToTry be the list ("toString", "valueOf").
2. Else
Let propertyNamesToTry be the list ("valueOf", "toString").

3. For each /propertyName/ in /propertyNamesToTry/ in order, do:
a. Let /propertyValue/ be the result of calling the [[Get]]
internal method of object /O/ with argument /propertyName/.
b. ReturnIfAbrupt(/propertyValue/).
c. If IsCallable(/propertyValue/) is true then,
i. Let /callResult/ be the result of calling the
[[Call]] internal method of /propertyValue/,
with /O/ as the this value and an empty argument list.
ii. ReturnIfAbrupt(/callResult/).
iii. If /callResult/ is a primitive value, return /callResult/.

4. Throw a TypeError exception.

---

• commentid: 5957
• comment_count: 1
• who: Allen Wirfs-Brock
• bug_when: 2013-10-22 18:36:36 -0700

fixed in rev20 editor's draft

7.1.1

---

• commentid: 6048
• comment_count: 2
• who: Allen Wirfs-Brock
• bug_when: 2013-10-29 09:45:09 -0700

fixed in rev20 draft, Oct. 28, 2013