« Bugzilla Issues Index
#3750 — refactor away LinkModules
- bug_id:
3750
- creation_ts:
2015-02-04 13:41:00 -0800
- short_desc:
refactor away LinkModules
- delta_ts:
2015-02-19 19:10:56 -0800
- product:
Draft for 6th Edition
- component:
Modules
- version:
Rev 32: February 2, 2015 Draft
- rep_platform:
All
- op_sys:
All
- bug_status:
RESOLVED
- resolution:
FIXED
- priority:
Normal
- bug_severity:
enhancement
- everconfirmed:
true
- reporter:
Dave Herman
- assigned_to:
Allen Wirfs-Brock
- cc:
["dherman", "jorendorff", "samth"]
- commentid:
12109
- comment_count:
0
- who:
Dave Herman
- bug_when:
2015-02-04 13:41:59 -0800
Linking is built-in to the behavior of the Module Record :: Instantiate operation (the renaming of ModuleDeclarationInstantiation -- see bug 3747); the only role of LinkModules was to do this on a collection of modules. But since TopLevelModuleEvaluationJob (see bug 3749) only has to link a single module and assumes all its dependencies are already linked, it can just directly call Instantiate on that module. LinkModules itself is unused and goes away.
Dave
- commentid:
12110
- comment_count:
1
- who:
Dave Herman
- bug_when:
2015-02-04 13:44:21 -0800
See https://gist.github.com/dherman/cad85565e0eb16d0a22d for details.
Dave
- commentid:
12857
- comment_count:
2
- who:
Allen Wirfs-Brock
- bug_when:
2015-02-17 17:30:51 -0800
fixed in rev34 editor's draft
- commentid:
13052
- comment_count:
3
- who:
Allen Wirfs-Brock
- bug_when:
2015-02-19 19:10:56 -0800
fixed in rev34